codenvy-1871: avoid iframe script execution on source changes #4504
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ann Shumilova <[email protected]>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2242/ |
akurinnoy
approved these changes
Mar 23, 2017
olexii4
approved these changes
Mar 23, 2017
benoitf
approved these changes
Mar 23, 2017
ashumilova
added
the
kind/bug
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ann Shumilova [email protected]
What does this PR do?
This PR fixes problem with execution the iframe scripts on source changes. What we have now: the iframe with IDE is not loaded yet and we change it's source, the previous scripts start getting canceled requests status and throw initialization errors. Removing iframe from DOM fixes the problem.
What issues does this PR fix or reference?
codenvy/codenvy#1871 (not related to teams, it's quick workspace switching in navbar bug)
Changelog
[UD] Avoid any IDE iframe script execution, when not loaded yet and source changes.
Release Notes
N/A
Docs PR
N/A