Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Optimize load resources operations #4505

Merged
merged 18 commits into from
Mar 24, 2017
Merged

Optimize load resources operations #4505

merged 18 commits into from
Mar 24, 2017

Conversation

vzhukovs
Copy link
Contributor

This changes proposal provides optimized mechanism for operating with resources and proposes several fixes, especially:

Changed mechanism of copying/moving files

Previous behavior performed revealing each copied/moved resource in destination path.
New behavior performs revealing only last operated resource in destination path.

Changes in retrieving list of resources from the server

Previous behavior of method org.eclipse.che.ide.resources.impl.ResourceManager#findResource calculated entire depth to resource which should be loaded and loaded entire tree with given depth.
New behavior performs only retrieving a resource only by given path.

Using jdk 8 features

Anonymous classes were replaced with lambdas for code readability.

What issues does this PR fix or reference?

#3891
#4205
#3847

Changelog

Optimize load resources operations

Release Notes

N/A

Docs PR

N/A

Vladyslav Zhukovskii added 14 commits March 14, 2017 18:16
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/ide labels Mar 22, 2017
@vzhukovs vzhukovs self-assigned this Mar 22, 2017
@vzhukovs vzhukovs requested a review from vparfonov March 22, 2017 08:54
Vladyslav Zhukovskii added 2 commits March 22, 2017 12:07
Signed-off-by: Vladyslav Zhukovskii <[email protected]>
@codenvy-ci
Copy link

@codenvy-ci
Copy link

Signed-off-by: Vladyslav Zhukovskii <[email protected]>
@codenvy-ci
Copy link

@vzhukovs vzhukovs changed the title [wip] Optimize load resources operations Optimize load resources operations Mar 24, 2017
@vzhukovs vzhukovs merged commit 6f97130 into master Mar 24, 2017
@vzhukovs vzhukovs deleted the che#3891 branch March 24, 2017 12:27
@vzhukovs vzhukovs added this to the 5.6.0 milestone Mar 24, 2017
@JamesDrummond JamesDrummond mentioned this pull request Apr 2, 2017
9 tasks
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* Reveal only last copied or moved resource

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Code optimization

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Update code base to java 8

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Code optiomizations

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Code optimizations

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Code optimizations

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Code refactorings

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Code cleanup

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Reformat code

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Use lambdas

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Extract duplicated code into standalone method

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Code optimization

Signed-off-by: Vladyslav Zhukovskii <[email protected]>

* Code refactoring

Signed-off-by: Vladyslav Zhukovskii <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants