Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Intelligent Commands bug fixes and code refactoring #4745

Merged
merged 3 commits into from
Apr 10, 2017
Merged

Intelligent Commands bug fixes and code refactoring #4745

merged 3 commits into from
Apr 10, 2017

Conversation

azatsarynnyy
Copy link
Member

@azatsarynnyy azatsarynnyy commented Apr 10, 2017 •
edited
Loading

What does this PR do?

Fixes several bugs related to Execute Command buttons on Commands toolbar.
More precisely:

  • fixes resetting a default command after any command modifications;
  • fixes tooltip for Execute Command button in case more than one machine is launching in the workspace;
  • fixes NPE on opening Commands Palette;
  • adds events for listening to commands modifications: CommandAddedEvent, CommandRemovedEvent, CommandUpdatedEvent, CommandsLoadedEvent;
  • does minor code refactoring.

What issues does this PR fix or reference?

#4674
#4625

Changelog

Fixes several bugs related to Execute Command buttons on Commands toolbar

Release Notes

Introduced events for listening to commands modifications:

  • org.eclipse.che.ide.api.command.CommandAddedEvent for listening to adding new command;
  • org.eclipse.che.ide.api.command.CommandRemovedEvent for listening to removing command;
  • org.eclipse.che.ide.api.command.CommandUpdatedEvent for listening to editing command;
  • org.eclipse.che.ide.api.command.CommandsLoadedEvent for listening to when all commands are loaded from the server.

Docs PR

N/A

@azatsarynnyy azatsarynnyy requested a review from vparfonov April 10, 2017 08:06
@codenvy-ci
Copy link

Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2423/

@azatsarynnyy azatsarynnyy merged commit 72852b6 into master Apr 10, 2017
@azatsarynnyy azatsarynnyy deleted the CHE-4511 branch April 10, 2017 12:18
@JamesDrummond JamesDrummond added this to the 5.8.0 milestone Apr 26, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
@azatsarynnyy
Intelligent Commands bug fixes and code refactoring (eclipse-che#4745)
e222048 
* fix resetting a default command after any command modifications;
* fix tooltip for Execute Command button in case more than one machine is launching in the workspace;
* fix NPE on opening Commands Palette;
* add events for listening to commands modifications: CommandAddedEvent, CommandRemovedEvent, CommandUpdatedEvent, CommandsLoadedEvent;
minor code refactoring.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vparfonov vparfonov vparfonov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
5.8.0
Development

Successfully merging this pull request may close these issues.
4 participants
@azatsarynnyy @codenvy-ci @vparfonov @JamesDrummond