CHE-4865: Correctly detect installed java version #4870
Conversation
tolusha
added
kind/bug
|
Tested with |
| @@ -52,8 +52,8 @@ INSTALL_JDK=false | |||
| command -v ${JAVA_HOME}/bin/java >/dev/null 2>&1 || { | |||
| INSTALL_JDK=true; | |||
| } && { | |||
| java_version=$(${JAVA_HOME}/bin/java -version 2>&1 | sed 's/.* version "\\(.*\\)\\.\\(.*\\)\\..*"/\\1\\2/; 1q') | |||
| if [ ! -z "${java_version##*[!0-9]*}" ] && [ "${java_version}" -lt "18" ]; then | |||
| java_version=$(${JAVA_HOME}/bin/java -version 2>&1 | grep version | awk '{print $NF}' | sed 's/"//g' | cut -d '.' -f2) | |||
There was a problem hiding this comment.
There is no checks that awk is present in container. awk is used in centos check, so I supose in works on centos but how to be sure it works in other images?.
There was a problem hiding this comment.
What about user's custom images? Have we declared that awk is mandatory in dev machine?
There was a problem hiding this comment.
Library images for alpine, busybox, ubuntu, debian, centos, fedora and rhel have awk.
Also, in all other agents we use awk - so far so good. So, if we are to check if awk is available, then we should do it across all agent scripts. However, having a custom image without awk is quite uncommon I think (maybe some super stripped images)
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2477/ |
ghost
merged commit 
* CHE-4865: Correctly detect installed java version * Fix up
What does this PR do?
Correctly detect installed java version
What issues does this PR fix or reference?
#4865
Changelog
Correctly detect installed java version
Release Notes
not required
Docs PR
not required