[cli] Use of version_lt function instead of less_than function #5141
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
less_than is not working with for example “5.9.1” and “5.10.0”, 5.9.0 being said to be a greater version bash-4.3# version_lt "5.9.0" "5.10.1" —> 0 bash-4.3# less_than "5.9.0" "5.10.1" —> 1 bash-4.3# less_than "5.6" "5.8" —> 0 Change-Id: I33417f012c193416bfb746df125c19e92a868b4e note: version_lt is a less and equals method, so we need to exclude the condition : tag == base version Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
kind/bug
benoitf
added
the
status/code-review
slemeur
approved these changes
May 19, 2017
riuvshin
approved these changes
May 19, 2017
benoitf
removed
the
status/code-review
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2638/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
less_than is not working with for example “5.9.1” and “5.10.0”, 5.9.0 being said to be a greater version bash-4.3# version_lt "5.9.0" "5.10.1" —> 0 bash-4.3# less_than "5.9.0" "5.10.1" —> 1 bash-4.3# less_than "5.6" "5.8" —> 0 Change-Id: I33417f012c193416bfb746df125c19e92a868b4e note: version_lt is a less and equals method, so we need to exclude the condition : tag == base version Signed-off-by: Florent BENOIT <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
less_than is not working with for example “5.9.1” and “5.10.0”, 5.9.0 being said to be a greater version
bash-4.3# version_lt "5.9.0" "5.10.1"
—> 0
bash-4.3# less_than "5.9.0" "5.10.1"
—> 1
bash-4.3# less_than "5.6" "5.8"
—> 0
note: version_lt is a less and equals method, so we need to exclude the condition : tag == base version
What issues does this PR fix or reference?
#5140
Changelog
Fix comparing versions in the check of newer docker CLI versions.
Release Notes
CLI: Fixed comparing versions in the check of newer docker CLI versions.
Docs PR
N/A (bug)
Change-Id: I33417f012c193416bfb746df125c19e92a868b4e
Signed-off-by: Florent BENOIT [email protected]