Move exec-agent/process -> core/process #5184
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
voievodin
force-pushed
the
goagents_process_move
branch
from
b22f95a to
189ca04
Compare
garagatyi
approved these changes
May 24, 2017
| // | ||
| // death bound now | ||
| // v v | ||
| // timeline -> 1 --- 2 --- 3 --- 4 --- 5 --- 6 --- 7 -> |
There was a problem hiding this comment.
This scheme makes it really clear - good idea!
BTW can you consider the addition of CleanupThreshold value that is used in pseudographics?
voievodin
force-pushed
the
goagents_process_move
branch
from
189ca04 to
bc0f67e
Compare
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2658/ |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Moves exec-agent/process package to core/process.
Doesn't require process logs dir, if it's not set the logs won't be written to fs.
Fixes
go test -racewarnings.Changes the behaviour of the
process.Cleanernow it cleans those processes which were dead for more than configured time.What issues does this PR fix or reference?
Resolves #5131
Changelog
Moves exec-agent/process package to core/process