Use internal IP if specified. Else on Linux it is not matching the expecting interface #5275
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…pecting interface name. Change-Id: I62c766a3ef8dd1dac6831a5fbc986e555b14586b Signed-off-by: Florent BENOIT <[email protected]>
benoitf
added
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/2740/ |
slemeur
approved these changes
Jun 2, 2017
skabashnyuk
approved these changes
Jun 3, 2017
ghost
approved these changes
Jun 3, 2017
benoitf
removed
the
status/code-review
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Routes created for Traefik were not containing the same ip than the hosts returned by the /api/workspace runtime links, so the routes didn't match and all traffic was routed to the default route : workspace master
What issues does this PR fix or reference?
#5240
Changelog
Use CHE_IP system provoperty if defined.
Change-Id: I62c766a3ef8dd1dac6831a5fbc986e555b14586b
Signed-off-by: Florent BENOIT [email protected]