CHE-5505: Fix NPE in DockerConnector #5510
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mykola Morhun <[email protected]>
ghost
approved these changes
Jun 30, 2017
AndrienkoAleksandr
approved these changes
Jun 30, 2017
garagatyi
reviewed
Jun 30, 2017
| return GSON.fromJson(reader, clazz); | ||
| T objectFromJson = GSON.fromJson(reader, clazz); | ||
| if (objectFromJson == null) { | ||
| throw new IOException("Docker responded with an empty stream."); |
There was a problem hiding this comment.
Empty stream says nothing to a user I suppose. And in certain cases, e.g. 301 or 201, an empty body is OK, so this message can be frustrating a bit.
WDYT about next code instead:
LOG.error("Docker response doesn't contain any data, though it was expected to contain some. Stack trace: {}", Thread.currentThread().getStackTrace());
throw new IOException("Internal server error. Unexpected response body from Docker daemon received.");
There was a problem hiding this comment.
Agree, this will be better.
Signed-off-by: Mykola Morhun <[email protected]>
garagatyi
approved these changes
Jun 30, 2017
|
Build # 2965 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2965/ to view the results. |
slemeur
added
the
kind/bug
|
@mmorhun : Please assign milestone and label when merging. |
JPinkney
pushed a commit
to JPinkney/che
that referenced
this pull request
Aug 17, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fixes NPE in
DockerConnectorwhen Docker respond with 200 response code and empty stream.What issues does this PR fix or reference?
#5505
Changelog
Fixed NPE when docker responds with 200 response code and empty stream.
Release Notes
N/A
Docs PR
N/A