Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ability to handle import logs from multiple projects #5511

Merged
merged 2 commits into from
Jul 3, 2017
Merged

Conversation

vzhukovs
Copy link
Contributor

What does this PR do?

Add ability to transmit importer logs from multiple project at the same time.

What issues does this PR fix or reference?

#5428

Changelog

Add ability to transmit importer logs from multiple project at the same time

Release Notes

N/A

Docs PR

N/A

@vzhukovs vzhukovs added kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system. team/plugin labels Jun 30, 2017
@vzhukovs vzhukovs self-assigned this Jun 30, 2017
@vzhukovs vzhukovs requested review from ashumilova and vparfonov June 30, 2017 16:09
@codenvy-ci
Copy link

Build # 2970 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/2970/ to view the results.

eventBus.addHandler(WsAgentStateEvent.TYPE, new WsAgentStateHandler() {
@Override
public void onWsAgentStarted(WsAgentStateEvent event) {
transmitter.newRequest().endpointId(WS_AGENT_ENDPOINT).methodName(EVENT_IMPORT_OUTPUT_SUBSCRIBE).noParams().sendAndSkipResult();
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

formatting issue

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@vparfonov vparfonov requested review from dkulieshov and vparfonov July 3, 2017 06:53
@codenvy-ci
Copy link

@Singleton
public class ProjectImportNotificationSubscriber {

public static final String WS_AGENT_ENDPOINT = "ws-agent";
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

may this property be defined at one place similar to AppContext one?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it's an endpoint id which is not stored in application context

@vzhukovs vzhukovs merged commit a5e3b05 into master Jul 3, 2017
@vzhukovs vzhukovs deleted the che#5428 branch July 3, 2017 12:29
@vzhukovs vzhukovs modified the milestones: 5.14.0, 5.15.0 Jul 3, 2017
JPinkney pushed a commit to JPinkney/che that referenced this pull request Aug 17, 2017
* Ability to handle import logs from multiple projects

* Formatting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template. severity/P1 Has a major impact to usage or development of the system.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants