Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Openshift : add mounted volume for logs #5708

Merged
merged 1 commit into from
Jul 18, 2017

Conversation

benoitf
Copy link
Contributor

@benoitf benoitf commented Jul 17, 2017

What does this PR do?

Adds a /workspace-logs folder linked to the persistent volume
Each pod has a dedicated folder matching the workspace id for the project's source, it is currently using : /projects ---> <PV>/<workspace-name> and for the logs it's now using as well /workspace-logs ---> <PV>/<workspace-name>-logs/

example : /workspace-logs/dev-machine-ws-agent/logs/catalina.log for the log of the dev-machine workspace agent.

What issues does this PR fix or reference?

redhat-developer/rh-che#145

Changelog

Add folder (/workspace-logs) on OpenShift linked to persistent volume

Release Notes

N/A

Docs PR

N/A

@benoitf benoitf added sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. team/californication labels Jul 17, 2017
@benoitf benoitf self-assigned this Jul 17, 2017
@benoitf benoitf requested review from l0rd and sunix July 17, 2017 15:07
@codenvy-ci
Copy link

Build # 3081 - FAILED

Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3081/ to view the results.

Copy link
Contributor

@l0rd l0rd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I've tested on OSIO and it works great! Thanks @benoitf

@l0rd
Copy link
Contributor

l0rd commented Jul 18, 2017

@benoitf @sunix what about merging that on master branch instead of openshift-connector-wip?

@benoitf
Copy link
Contributor Author

benoitf commented Jul 18, 2017

@l0rd I'm fine with both ways

@benoitf benoitf changed the base branch from openshift-connector-wip to master July 18, 2017 11:54
Each pod has a dedicated folder matching the workspace id

for the project's source, it is currently using :

/projects ---> <PV>/<workspace-name>

and for the logs it's now using as well
/workspace-logs ---> <PR>/<workspace-name>-logs/

example : /workspace-logs/dev-machine-ws-agent/logs/catalina.log  for the log of the dev-machine workspace agent.

Change-Id: I2b9d533ba3df2cf55857d8c30d2de5df463a5902
Signed-off-by: Florent BENOIT <[email protected]>
@benoitf benoitf force-pushed the openshift-add-volume-for-logs branch from 73d6fc5 to 132496e Compare July 18, 2017 12:00
@benoitf
Copy link
Contributor Author

benoitf commented Jul 18, 2017

I've updated target branch to master

@l0rd
Copy link
Contributor

l0rd commented Jul 18, 2017

👍

Copy link
Contributor

@sunix sunix left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@benoitf benoitf merged commit 4e872e0 into master Jul 18, 2017
@benoitf benoitf deleted the openshift-add-volume-for-logs branch July 18, 2017 13:23
@benoitf benoitf removed sprint/current status/code-review This issue has a pull request posted for it and is awaiting code review completion by the community. labels Jul 18, 2017
@benoitf benoitf added this to the 5.15.0 milestone Jul 18, 2017
@codenvy-ci
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants