-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Openshift : add mounted volume for logs #5708
Conversation
Build # 3081 - FAILED Please check console output at https://ci.codenvycorp.com/job/che-pullrequests-build/3081/ to view the results. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've tested on OSIO and it works great! Thanks @benoitf
@l0rd I'm fine with both ways |
Each pod has a dedicated folder matching the workspace id for the project's source, it is currently using : /projects ---> <PV>/<workspace-name> and for the logs it's now using as well /workspace-logs ---> <PR>/<workspace-name>-logs/ example : /workspace-logs/dev-machine-ws-agent/logs/catalina.log for the log of the dev-machine workspace agent. Change-Id: I2b9d533ba3df2cf55857d8c30d2de5df463a5902 Signed-off-by: Florent BENOIT <[email protected]>
73d6fc5
to
132496e
Compare
I've updated target branch to master |
👍 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3093/ |
What does this PR do?
Adds a
/workspace-logs
folder linked to the persistent volumeEach pod has a dedicated folder matching the workspace id for the project's source, it is currently using :
/projects ---> <PV>/<workspace-name>
and for the logs it's now using as well/workspace-logs ---> <PV>/<workspace-name>-logs/
example :
/workspace-logs/dev-machine-ws-agent/logs/catalina.log
for the log of the dev-machine workspace agent.What issues does this PR fix or reference?
redhat-developer/rh-che#145
Changelog
Add folder (/workspace-logs) on OpenShift linked to persistent volume
Release Notes
N/A
Docs PR
N/A