CHE-5643. Add ability to select items in the quick fix window using keyboard #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
RomanNikitenko
added
the
kind/bug
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3131/ |
svor
reviewed
Jul 21, 2017
| return; | ||
| } | ||
|
|
||
| if (currentSelectedElement == elementToSelect) { |
There was a problem hiding this comment.
try to use currentSelectedElement.isEqualNode(elementToSelect)
There was a problem hiding this comment.
@svor fixed, thank you!
svor
approved these changes
Jul 21, 2017
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3138/ |
vparfonov
approved these changes
Jul 21, 2017
|
ci-test |
|
ci-test build report: |
Ohrimenko1988
approved these changes
Jul 24, 2017
evidolob
approved these changes
Jul 24, 2017
…eyboard Signed-off-by: Roman Nikitenko <[email protected]>
slemeur
added
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Add ability to select items in the quick fix window using keyboard
What issues does this PR fix or reference?
#5643
Changelog
Add ability to select items in the quick fix window using keyboard
Signed-off-by: Roman Nikitenko [email protected]