Adding debug commands for vertx & spring-boot stacks #5938
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Ilya Buziuk <[email protected]>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
ghost
approved these changes
Aug 8, 2017
|
commands are ok but it looks like the port for debugging (5005) is not exposed on the docker images. |
|
@benoitf there's no need to expose it unless you need to remotely debug the app. Otherwise, Che debugger connects to localhost:5005 |
|
@eivantsov yes I was thinking on remote debugging as well but it's not the primary case. |
benoitf
approved these changes
Aug 8, 2017
ashumilova
approved these changes
Aug 10, 2017
slemeur
added
the
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Ilya Buziuk [email protected]
What does this PR do?
Adds debug commands for 'vert.x' and 'spring-boot' stacks
What issues does this PR fix or reference?
redhat-developer/rh-che#238
Changelog
Adding debug commands for 'vert.x' and 'spring-boot' stacks
Release Notes
Debug commands for 'vert.x' and 'spring-boot' stacks
Docs PR
N / A