Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix gulp test task execution #6171

Merged
merged 1 commit into from
Sep 8, 2017
Merged

Fix gulp test task execution #6171

merged 1 commit into from
Sep 8, 2017

Conversation

ashumilova
Copy link
Contributor

Signed-off-by: Anna Shumilova [email protected]

What does this PR do?

Fixes the gulp test task execution.

What issues does this PR fix or reference?

Docs PR

N/A

@ashumilova ashumilova added the kind/bug Outline of a bug - must adhere to the bug report template. label Sep 7, 2017
@ashumilova ashumilova added this to the 5.18.0 milestone Sep 7, 2017
@ashumilova ashumilova self-assigned this Sep 7, 2017
@benoitf
Copy link
Contributor

benoitf commented Sep 7, 2017

does it need too be activated there as well ?
https://github.com/eclipse/che/blob/master/dashboard/Dockerfile#L20

RUN apk update && \
apk add --no-cache git
RUN apt-get update && \
apt-get install -y git
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

we should add

    && apt-get -y clean \
    && rm -rf /var/lib/apt/lists/* && \

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

as now it's switched to debian

@codenvy-ci
Copy link

Signed-off-by: Anna Shumilova <[email protected]>
@ashumilova ashumilova merged commit b952135 into master Sep 8, 2017
@ashumilova ashumilova deleted the fix_gulp_test branch September 8, 2017 07:26
@codenvy-ci
Copy link

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind/bug Outline of a bug - must adhere to the bug report template.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants