Che dockerfiles: apply chmod only to folders to fool COW #6272
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Mario Loriedo <[email protected]>
|
Can one of the admins verify this patch? |
1 similar comment
|
Can one of the admins verify this patch? |
benoitf
approved these changes
Sep 14, 2017
benoitf
reviewed
Sep 14, 2017
| @@ -40,4 +40,4 @@ ENTRYPOINT ["/entrypoint.sh"] | |||
| RUN mkdir /logs /data && \ | |||
There was a problem hiding this comment.
I don't remember why this instruction couldn't be merged with previous RUN instruction ?
There was a problem hiding this comment.
@benoitf I don't think we have ever discussed that
There was a problem hiding this comment.
AFAIK It was discussed there #6200 (review)
There was a problem hiding this comment.
Anyway I can't see any problem to do it. But it should be carefully tested.
l0rd
added
the
kind/enhancement
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Modify Che alpine and CentOS based Dockerfiles to apply chmod only to folders.
What issues does this PR fix or reference?
#6200 (comment): this single instruction at the end of the Dockerfile added a layer of ~185M
RUN chmod -R 0777 /home/userThat's because of copy on write: every file which permissions have been modified is duplicated in the new layer. To avoid that (and fool cow) we apply chmod only to folders: