Fix and improve some actions #6287
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Aleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Oleksandr Andriienko <[email protected]>
Signed-off-by: Aleksandr Andriienko <[email protected]>
tolusha
reviewed
Sep 15, 2017
| new EditorAgent.OpenEditorCallback() { | ||
| @Override | ||
| public void onEditorOpened(EditorPartPresenter editor) { | ||
| new Timer() { |
There was a problem hiding this comment.
Move
new Timer() {
...
inside scrollToLine method
tolusha
approved these changes
Sep 15, 2017
vzhukovs
approved these changes
Sep 15, 2017
Signed-off-by: Aleksandr Andriienko <[email protected]>
Signed-off-by: Aleksandr Andriienko <[email protected]>
|
Build success. https://ci.codenvycorp.com/job/che-pullrequests-build/3701/ |
vparfonov
approved these changes
Sep 15, 2017
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What does this PR do?
Fix scroll to line for OpenFileAction.java. Fix broken "Link with editor" button and RevealResourceAction.java . Improve RevealResourceAction.java : added property "path" to reveal node. Add method "addSelectionHandler" to ProjectExplorerTree.
What issues does this PR fix or reference?
#6285
#6286
codenvy/redhat#30
Changelog
Release Notes
Docs PR
Don't need: little enhancements and bug fixes.