Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactoring: Move #1089

Closed
3 tasks done
testforstephen opened this issue Jul 4, 2019 · 2 comments
Closed
3 tasks done

Refactoring: Move #1089

testforstephen opened this issue Jul 4, 2019 · 2 comments
Assignees
@testforstephen
Labels
code-actions enhancement
Milestone
End August 2019

Comments

@testforstephen
Copy link
Contributor

testforstephen commented Jul 4, 2019 •
edited
Loading

  • Move class/file to other package
  • Move members to other classes
  • Move inner type to new File
@testforstephen testforstephen self-assigned this Jul 4, 2019
@testforstephen testforstephen mentioned this issue Jul 12, 2019
Merged
@testforstephen
Copy link
Contributor Author

Currently jdt code is placed at jdt.ui, need refactor classes below to jdt.core.manipulation first.

  • org.eclipse.jdt.internal.corext.refactoring.structure.MoveInstanceMethodProcessor
  • org.eclipse.jdt.internal.corext.refactoring.structure.MoveStaticMembersProcessor
  • org.eclipse.jdt.internal.corext.refactoring.structure.MoveInnerToTopRefactoring

@testforstephen
Copy link
Contributor Author

Submitted a gerrit patch https://git.eclipse.org/r/#/c/146721/ to refactor MoveInstanceMethodProcessor and MoveStaticMembersProcessor in the upstream jdt.ui.

cc @jjohnstn @rgrunber @fbricon

@testforstephen testforstephen mentioned this issue Aug 8, 2019
Merged
@testforstephen testforstephen mentioned this issue Aug 23, 2019
Merged
@fbricon fbricon added this to the End August 2019 milestone Sep 2, 2019
@fbricon fbricon closed this as completed Sep 2, 2019
@fbricon fbricon mentioned this issue Sep 2, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@testforstephen testforstephen

Labels
code-actions enhancement
Projects
None yet
Milestone
End August 2019
Development

No branches or pull requests
2 participants
@fbricon @testforstephen