Code folding is buggy #1419

Yanpas · 2020-04-27T15:34:59Z

Sometimes folding ranges are out of sync and located 1 line below or upwards. Sometimes they are completely broken with following exception:

[Error - 18:29:56] 27 апр. 2020 г., 18:29:56 Problem with folding range for XXX.java:
Invalid_Char_In_String
org.eclipse.jdt.core.compiler.InvalidInputException: Invalid_Char_In_String
	at org.eclipse.jdt.internal.core.util.PublicScanner.getNextToken(PublicScanner.java:1564)
	at org.eclipse.jdt.ls.core.internal.handlers.FoldingRangeHandler.computeFoldingRanges(FoldingRangeHandler.java:112)
	at org.eclipse.jdt.ls.core.internal.handlers.FoldingRangeHandler.foldingRange(FoldingRangeHandler.java:63)
	at org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer.lambda$27(JDTLanguageServer.java:814)
	at org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer.lambda$49(JDTLanguageServer.java:950)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:642)
	at java.base/java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:479)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1016)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1665)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1598)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)

STR:

Add some parameter to the method used across class
For some time method call will be causing compile error
Fix it by adding desired argument
Code folding is broken!!!

The text was updated successfully, but these errors were encountered:

fbricon · 2020-04-27T15:54:39Z

this is weird, as we're waiting for the document to be reconciled properly before computing folding ranges in https://github.com/eclipse/eclipse.jdt.ls/blame/1cc049e2d19bba5e31f94032c4851fd0a5840bea/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/JDTLanguageServer.java#L813

@testforstephen @jdneo @snjeza any ideas?

Yanpas · 2020-04-27T16:04:43Z

More details:

extension version 0.60
jdk 13
arch linux
I use eclipse project (.project, .settings etc)
I use splitting the same editor.

fbricon · 2020-04-27T16:14:17Z

0.60.0 as in vscode-java?

Yanpas · 2020-04-27T16:16:29Z

Yes, it's vscode extension's version.

More traces (not sure if they are related) Even without splitting editor foldings disappear after some edits:


[Error - 19:14:23] Request textDocument/codeAction failed.
  Message: Internal error.
  Code: -32603 
java.util.concurrent.CompletionException: java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1
	at java.base/java.util.concurrent.CompletableFuture.encodeThrowable(CompletableFuture.java:314)
	at java.base/java.util.concurrent.CompletableFuture.completeThrowable(CompletableFuture.java:319)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:645)
	at java.base/java.util.concurrent.CompletableFuture$Completion.exec(CompletableFuture.java:479)
	at java.base/java.util.concurrent.ForkJoinTask.doExec(ForkJoinTask.java:290)
	at java.base/java.util.concurrent.ForkJoinPool$WorkQueue.topLevelExec(ForkJoinPool.java:1016)
	at java.base/java.util.concurrent.ForkJoinPool.scan(ForkJoinPool.java:1665)
	at java.base/java.util.concurrent.ForkJoinPool.runWorker(ForkJoinPool.java:1598)
	at java.base/java.util.concurrent.ForkJoinWorkerThread.run(ForkJoinWorkerThread.java:177)
Caused by: java.lang.IndexOutOfBoundsException: Index 1 out of bounds for length 1
	at java.base/jdk.internal.util.Preconditions.outOfBounds(Preconditions.java:64)
	at java.base/jdk.internal.util.Preconditions.outOfBoundsCheckIndex(Preconditions.java:70)
	at java.base/jdk.internal.util.Preconditions.checkIndex(Preconditions.java:248)
	at java.base/java.util.Objects.checkIndex(Objects.java:373)
	at java.base/java.util.ArrayList.get(ArrayList.java:425)
	at org.eclipse.jdt.core.dom.ASTNode$NodeList.get(ASTNode.java:1472)
	at org.eclipse.jdt.internal.corext.refactoring.code.SourceProvider.getParameterData(SourceProvider.java:316)
	at org.eclipse.jdt.internal.corext.refactoring.code.CallInliner.computeRealArguments(CallInliner.java:474)
	at org.eclipse.jdt.internal.corext.refactoring.code.CallInliner.initialize(CallInliner.java:256)
	at org.eclipse.jdt.internal.corext.refactoring.code.InlineMethodRefactoring.checkFinalConditions(InlineMethodRefactoring.java:311)
	at org.eclipse.ltk.core.refactoring.CheckConditionsOperation.run(CheckConditionsOperation.java:86)
	at org.eclipse.ltk.core.refactoring.CreateChangeOperation.run(CreateChangeOperation.java:122)
	at org.eclipse.jdt.ls.core.internal.corrections.RefactorProcessor.getInlineProposal(RefactorProcessor.java:353)
	at org.eclipse.jdt.ls.core.internal.corrections.RefactorProcessor.getProposals(RefactorProcessor.java:143)
	at org.eclipse.jdt.ls.core.internal.handlers.CodeActionHandler.getCodeActionCommands(CodeActionHandler.java:121)
	at org.eclipse.jdt.ls.core.internal.handlers.JDTLanguageServer.lambda$14(JDTLanguageServer.java:620)
	at org.eclipse.jdt.ls.core.internal.BaseJDTLanguageServer.lambda$0(BaseJDTLanguageServer.java:74)
	at java.base/java.util.concurrent.CompletableFuture$UniApply.tryFire(CompletableFuture.java:642)
	... 6 more

[Error - 19:15:02] 27 апр. 2020 г., 19:15:02 Problems occurred when invoking code from plug-in: "org.eclipse.core.resources".
null
java.lang.NullPointerException

fbricon · 2020-04-27T16:21:58Z

If you can reproduce the issue reliably, do you mind recording the steps you follow to see this issue?

Yanpas · 2020-04-27T16:39:57Z

Here it is: https://gist.github.com/Yanpas/7c92234ea1f2b2398dc5f6d4b94de6bf

Recorded with "java.trace.server": "messages",

What I was doing?

Folded several if's
Between class methods inserted this snippet:

int var;
    void foo() {}
    {

It makes whole piece of code uncompilable
3. then removed extra curly brace and folding is gone

Yanpas · 2020-04-27T16:42:00Z

Editing only one file causes a lot of files (I guess all) to recompile for some reasong, according to inotify watcher (inotifywait -r -m ~/ssd/work/trunk/EclipseBuild/)

fbricon · 2020-04-27T16:45:43Z

how many files do you have open?

Yanpas · 2020-04-27T16:59:39Z

2 or 3. Both from one package and project. My .classpath looks like:

<classpath>
        <classpathentry kind="con" path="org.eclipse.jdt.launching.JRE_CONTAINER/org.eclipse.jdt.internal.debug.ui.launcher.StandardVMType/JavaSE-1.8"/>
        <classpathentry kind="output" path="EclipseBuild"/>
        <classpathentry kind="lib" path="tmp/release/some.jar"/>
        <classpathentry kind="lib" path="tmp/release/another.jar"/>
        <!--... and 300+ more lib projects-->
        <classpathentry kind="src" path="projects/p1/java/src"/>
        <classpathentry kind="src" path="projects/p2/java/src"/>
        <!--... and 120+ more src projects-->
</classpath>

snjeza · 2020-04-27T18:28:42Z

@Yanpas could you send us the following:

your VS Code settings.json
the LANG environment variable

$ echo $LANG

ImageDataflow.java or non ASCII characters from this file

Yanpas · 2020-04-27T18:33:12Z

java settings:

    "[java]": {
        "editor.defaultFormatter": "redhat.java"
    },
    "java.errors.incompleteClasspath.severity": "ignore",
    "java.jdt.ls.vmargs": "-noverify -Xmx5G -XX:+UseG1GC -XX:+UseStringDeduplication",
    "java.configuration.checkProjectSettingsExclusions": false,
    "java.configuration.updateBuildConfiguration": "automatic",
    "java.import.gradle.enabled": false,
    "java.import.maven.enabled": false,

2.$ echo $LANG:
ru_RU.UTF-8
3. This file is utf8 encoded and has the following nonascii line for instance:
temp, // Директория с временными данными

snjeza · 2020-04-27T20:45:04Z

@Yanpas could you check it?

$ iconv -f UTF-8 ImageDataflow.java > /dev/null; echo $?

The command should return 0.

Yanpas · 2020-04-27T21:42:48Z

Return code is zero. Checked env of java process, it's correct:

pgrep java
cat /proc/91283/environ | tr '\0' '\n' |grep  LANG

snjeza · 2020-04-27T22:03:04Z

It makes whole piece of code uncompilable
3. then removed extra curly brace and folding is gone

I can't reproduce the issue.
Could you attach a sample project reproducing this issue?

Yanpas · 2020-04-27T22:35:08Z

Here is a screencast with two dummy files, one with non utf8 encoding. (Whi knows whether files with bad encoding exist in my real big project)

files.tgz.zip (is not zip, but tar.gz)

Yanpas · 2020-04-27T22:37:50Z

On my main project I guess it reproduces due to another issue - editing one file causes recalculation of all publishDiagnostics, some file may be broken.

snjeza · 2020-04-28T21:11:03Z

@Yanpas could you try to reproduce the issue related to code folding using https://raw.githubusercontent.com/snjeza/vscode-test/master/java-0.61.1.vsix ?

Yanpas · 2020-04-28T23:14:19Z

Played for a while, seems to be fixed, thank you!

Open new performance related issue #1425

fbricon added bug folding labels Apr 27, 2020

snjeza self-assigned this Apr 28, 2020

snjeza mentioned this issue Apr 28, 2020

Code folding is buggy #1424

Merged

fbricon closed this as completed in #1424 Apr 29, 2020

fbricon added this to the End April 2020 milestone Apr 29, 2020

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Code folding is buggy #1419

Code folding is buggy #1419

Yanpas commented Apr 27, 2020

fbricon commented Apr 27, 2020

Yanpas commented Apr 27, 2020

fbricon commented Apr 27, 2020

Yanpas commented Apr 27, 2020

fbricon commented Apr 27, 2020

Yanpas commented Apr 27, 2020

Yanpas commented Apr 27, 2020

fbricon commented Apr 27, 2020

Yanpas commented Apr 27, 2020

snjeza commented Apr 27, 2020 •

edited

Loading

Yanpas commented Apr 27, 2020

snjeza commented Apr 27, 2020

Yanpas commented Apr 27, 2020

snjeza commented Apr 27, 2020 •

edited

Loading

Yanpas commented Apr 27, 2020

Yanpas commented Apr 27, 2020

snjeza commented Apr 28, 2020

Yanpas commented Apr 28, 2020

Code folding is buggy #1419

Code folding is buggy #1419

Comments

Yanpas commented Apr 27, 2020

fbricon commented Apr 27, 2020

Yanpas commented Apr 27, 2020

fbricon commented Apr 27, 2020

Yanpas commented Apr 27, 2020

fbricon commented Apr 27, 2020

Yanpas commented Apr 27, 2020

Yanpas commented Apr 27, 2020

fbricon commented Apr 27, 2020

Yanpas commented Apr 27, 2020

snjeza commented Apr 27, 2020 • edited Loading

Yanpas commented Apr 27, 2020

snjeza commented Apr 27, 2020

Yanpas commented Apr 27, 2020

snjeza commented Apr 27, 2020 • edited Loading

Yanpas commented Apr 27, 2020

Yanpas commented Apr 27, 2020

snjeza commented Apr 28, 2020

Yanpas commented Apr 28, 2020

snjeza commented Apr 27, 2020 •

edited

Loading

snjeza commented Apr 27, 2020 •

edited

Loading