Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add code actions to add sealed/final/non-sealed modifier on a permitted type declaration. #1555

Closed
fbricon opened this issue Sep 28, 2020 · 2 comments · Fixed by #1557
Closed

Add code actions to add sealed/final/non-sealed modifier on a permitted type declaration. #1555

fbricon opened this issue Sep 28, 2020 · 2 comments · Fixed by #1557
Assignees
@rgrunber
Labels
code-actions enhancement Java 15
Milestone
Mid October 2020

Comments

@fbricon
Copy link
Contributor

fbricon commented Sep 28, 2020

Need to reuse Eclipse IDE's quick fixes to add sealed/final/non-sealed modifier on a permitted type declaration.:

  • Given a sealed ShapeClass class:

  • Given a sealed ShapeInterface interface:
@rgrunber
Copy link
Contributor

Looks like this is a matter of updating JDT-LS' QuickFixProcessor and migrating JDT's ModifierCorrectionSubProcessor#addSealedMissingModifierProposal(..) to JDT-LS.

rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Sep 29, 2020
@rgrunber
Add code actions to support new Java 15 modifiers on permitted class.
98e3e59 
- Add support for code actions to generate sealed/un-sealed/final
  modifiers on class with sealed direct super-class/super-interface
- Fixes eclipse-jdtls#1555

Signed-off-by: Roland Grunberg <[email protected]>
@rgrunber rgrunber mentioned this issue Sep 29, 2020
Merged
rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Sep 30, 2020
@rgrunber
Add code actions to support new Java 15 modifiers on permitted class.
602847b 
- Add support for code actions to generate sealed/un-sealed/final
  modifiers on class with sealed direct super-class/super-interface
- Fixes eclipse-jdtls#1555
- Add testcase

Signed-off-by: Roland Grunberg <[email protected]>
rgrunber added a commit to rgrunber/eclipse.jdt.ls that referenced this issue Oct 1, 2020
@rgrunber
Add code actions to support new Java 15 modifiers on permitted class.
71cfeb7 
- Add support for code actions to generate sealed/un-sealed/final
  modifiers on class with sealed direct super-class/super-interface
- Fixes eclipse-jdtls#1555
- Add testcase

Signed-off-by: Roland Grunberg <[email protected]>
fbricon pushed a commit that referenced this issue Oct 1, 2020
@rgrunber @fbricon
Add code actions to support new Java 15 modifiers on permitted class.
7909f23 
- Add support for code actions to generate sealed/un-sealed/final
  modifiers on class with sealed direct super-class/super-interface
- Fixes #1555
- Add testcase

Signed-off-by: Roland Grunberg <[email protected]>
@fbricon fbricon added this to the Mid October 2020 milestone Oct 1, 2020
@fbricon
Copy link
Contributor Author

fbricon commented Oct 1, 2020

Results in vscode-java:
Screen Shot 2020-10-01 at 5 06 34 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rgrunber rgrunber

Labels
code-actions enhancement Java 15
Projects
None yet
Milestone
Mid October 2020
Development

Successfully merging a pull request may close this issue.

Add code actions to support new Java 15 modifiers on permitted class. rgrunber/eclipse.jdt.ls
2 participants
@fbricon @rgrunber