Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove or refactor WorkspaceDiagnosticsHandler #468

Closed
snjeza opened this issue Nov 28, 2017 · 3 comments
Closed

Remove or refactor WorkspaceDiagnosticsHandler #468

snjeza opened this issue Nov 28, 2017 · 3 comments

Comments

@snjeza
Copy link
Contributor

snjeza commented Nov 28, 2017

Typescript LS reports errors only for opened files. We can do something similar if we remove WorkspaceDiagnosticsHandler. The errors for opened files are reported in DocumentLifeCycleHandler.performValidation().
If we want to keep WorkspaceDiagnosticsHandler, we can remove the POST_CHANGE event because the workspace's autobuilding property is set to true and all the errors are reported with the POST_BUILD event.
Currently, all the errors are being reported twice.
That will improve performance when using a bigger project.

@fbricon @gorkem WDYT?

@fbricon
Copy link
Contributor

fbricon commented Nov 28, 2017

Keeping workspace wide errors makes sense, but I reckon error reporting can be quite slow. I'd be happy to see a better performing version of it.
So make a PR and we'll see how it fares.

@gorkem
Copy link
Contributor

gorkem commented Nov 28, 2017

+1. We may actually have POST_CHANGE in there by mistake. In the early days the builds were not automatic.

@fbricon
Copy link
Contributor

fbricon commented Nov 28, 2017

I'm all for it as long as we don't introduce regressions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants