You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Typescript LS reports errors only for opened files. We can do something similar if we remove WorkspaceDiagnosticsHandler. The errors for opened files are reported in DocumentLifeCycleHandler.performValidation().
If we want to keep WorkspaceDiagnosticsHandler, we can remove the POST_CHANGE event because the workspace's autobuilding property is set to true and all the errors are reported with the POST_BUILD event.
Currently, all the errors are being reported twice.
That will improve performance when using a bigger project.
Keeping workspace wide errors makes sense, but I reckon error reporting can be quite slow. I'd be happy to see a better performing version of it.
So make a PR and we'll see how it fares.
Typescript LS reports errors only for opened files. We can do something similar if we remove WorkspaceDiagnosticsHandler. The errors for opened files are reported in DocumentLifeCycleHandler.performValidation().
If we want to keep WorkspaceDiagnosticsHandler, we can remove the POST_CHANGE event because the workspace's autobuilding property is set to true and all the errors are reported with the POST_BUILD event.
Currently, all the errors are being reported twice.
That will improve performance when using a bigger project.
@fbricon @gorkem WDYT?
The text was updated successfully, but these errors were encountered: