Broken import autocompletion

[fbricon]

Given (as a saved file):

package foo;

class Test{
}

typing import java.ut + tab to select the {} java.util completion, as in:

package foo;

import java.ut| //type the whole line without interruption

class Test {
}

leads to a broken completion:

package foo;

java.util.*;class Test {
}

Logged messages:

[Trace - 09:36:48] Sending request 'completionItem/resolve - (794)'.
Params: {
    "label": "java.util",
    "insertTextFormat": 1,
    "kind": 9,
    "sortText": "999999215",
    "data": {
        "pid": "10",
        "rid": "77",
        "uri": "file:/Users/fbricon/Dev/demos/spring-petclinic/src/main/java/foo/Test.java"
    }
}


[Trace - 09:36:48] Received response 'completionItem/resolve - (794)' in 4ms.
Result: {
    "label": "java.util",
    "kind": 9,
    "sortText": "999999215",
    "insertTextFormat": 2,
    "textEdit": {
        "range": {
            "start": {
                "line": 2,
                "character": 7
            },
            "end": {
                "line": 2,
                "character": 12
            }
        },
        "newText": "java.util.*;"
    },
    "additionalTextEdits": [
        {
            "range": {
                "start": {
                    "line": 0,
                    "character": 12
                },
                "end": {
                    "line": 5,
                    "character": 0
                }
            },
            "newText": "\n\n"
        }
    ]
}


[Trace - 09:36:48] Sending request 'textDocument/codeAction - (795)'.
Params: {
    "textDocument": {
        "uri": "file:///Users/fbricon/Dev/demos/spring-petclinic/src/main/java/foo/Test.java"
    },
    "range": {
        "start": {
            "line": 2,
            "character": 14
        },
        "end": {
            "line": 2,
            "character": 14
        }
    },
    "context": {
        "diagnostics": []
    }
}


[Trace - 09:36:48] Sending notification 'textDocument/didChange'.
Params: {
    "textDocument": {
        "uri": "file:///Users/fbricon/Dev/demos/spring-petclinic/src/main/java/foo/Test.java",
        "version": 19
    },
    "contentChanges": [
        {
            "range": {
                "start": {
                    "line": 0,
                    "character": 12
                },
                "end": {
                    "line": 5,
                    "character": 0
                }
            },
            "rangeLength": 19,
            "text": "\n\n"
        }
    ]
}

[fbricon]

Completion works fine if the compilation unit is already dirty (i.e not after opening or saving the file)

[rgrunber]

Does it make sense to revert #566 in the event that this basically introduced it ?

[fbricon]

No, the problem predates your patch.

[snjeza]

@fbricon Can you reproduce the issue when starting the server with -Djava.lsp.joinOnCompletion=true?
See #512 (comment)

[fbricon]

Can't reproduce anymore. Closing.