Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completion should provide code snippets (sysout/syserr/...) #977

Closed
ghost opened this issue Apr 4, 2019 · 5 comments
Closed

Completion should provide code snippets (sysout/syserr/...) #977

ghost opened this issue Apr 4, 2019 · 5 comments

Comments

@ghost
Copy link

ghost commented Apr 4, 2019

r

See image. This was reproduced on che.openshift.io but it seems that that doesn't make a difference.

@fbricon
Copy link
Contributor

fbricon commented Apr 4, 2019

this is not a jdt.ls issue, as that snippet comes directly from vscode-java. It is pretty dumb and blindly injects the full snippet at the cursor location.
So I won't close it but instead will turn it into a "provide sysout/syserr snippets" enhancement request. We'll then be able to remove the dumb snippets on the vscode-java side.

@fbricon fbricon changed the title Template completion not working as expected Completion should provide code snippets (sysout/syserr/...) Apr 4, 2019
@fbricon
Copy link
Contributor

fbricon commented Apr 4, 2019

Would love to see systrace exposed to jdt.ls too: https://twitter.com/EclipseJavaIDE/status/1113723686148767744

@testforstephen
Copy link
Contributor

The core template engine code is placed at jdt.ui bundle.

org.eclipse.jdt.internal.ui.text.template.contentassist.*
org.eclipse.jdt.internal.corext.template.java.*

To reuse it in jdt.ls, need refactor the upstream code first. Currently, the template code is mixed with some of ui logic, it takes a certain of effort to decouple the ui.

@testforstephen
Copy link
Contributor

@jdneo is working on this.

@testforstephen testforstephen removed their assignment Sep 27, 2019
@jdneo
Copy link
Contributor

jdneo commented Sep 27, 2019

Yes I'm now moving the related code from ui to core.manipulation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants