Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Optimize compilation unit computations #980

Closed
fbricon opened this issue Apr 4, 2019 · 0 comments
Closed

Optimize compilation unit computations #980

fbricon opened this issue Apr 4, 2019 · 0 comments
Assignees
@snjeza
Labels
enhancement performance
Milestone
Mid April 2019

Comments

@fbricon
Copy link
Contributor

fbricon commented Apr 4, 2019

As described in #824 (comment), a number of optimizations related to the way jdt.ls computes CompilationUnits could be implemented:

1 - org.eclipse.jdt.ls.core.internal.managers.ProjectsManager.fileChanged(String, CHANGE_TYPE) calls findFile twice in https://github.com/eclipse/eclipse.jdt.ls/blob/master/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/ProjectsManager.java#L254

2 - org.eclipse.jdt.ls.core.internal.JDTUtils.resolveCompilationUnit(URI) always creates a java element. I created only compilation units.

3 - org.eclipse.jdt.ls.core.internal.handlers.WorkspaceEventsHandler.createCompilationUnit(ICompilationUnit) ignores those units that aren't on the classpath
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@snjeza snjeza

Labels
enhancement performance
Projects
None yet
Milestone
Mid April 2019
Development

No branches or pull requests
2 participants
@fbricon @snjeza