Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add additional Gradle preferences #1092

Merged
merged 1 commit into from
Jul 8, 2019
Merged

Add additional Gradle preferences #1092

merged 1 commit into from
Jul 8, 2019

Conversation

gatesn
Copy link
Contributor

@gatesn gatesn commented Jul 5, 2019

Signed-off-by: Nicholas Gates [email protected]

@gatesn gatesn mentioned this pull request Jul 5, 2019
Closed
@fbricon fbricon requested a review from snjeza July 8, 2019 10:06
@fbricon
Copy link
Contributor

fbricon commented Jul 8, 2019

LGTM but I'd prefer @snjeza to double check.

@fbricon
Copy link
Contributor

fbricon commented Jul 8, 2019

3 new preferences are added:

  • java.import.gradle.arguments: arguments to pass to Gradle
  • java.import.gradle.jvmArguments: JVM arguments to pass to Gradle
  • java.import.gradle.home: setting for GRADLE_HOME

@fbricon fbricon merged commit 6fa7d16 into eclipse-jdtls:master Jul 8, 2019
@fbricon
Copy link
Contributor

fbricon commented Jul 8, 2019

Thanks @gatesn !

@fbricon fbricon added this to the Mid July 2019 milestone Jul 8, 2019
@gatesn gatesn deleted the ngates/gradle-preferences branch August 10, 2019 14:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@snjeza snjeza snjeza approved these changes

Assignees
No one assigned
Labels
enhancement gradle
Projects
None yet
Milestone
Mid July 2019
Development

Successfully merging this pull request may close these issues.
3 participants
@gatesn @fbricon @snjeza