NavigateToDefinitionHandler should not return null #1143
Conversation
|
Can one of the admins verify this patch? |
| @@ -45,7 +46,7 @@ public NavigateToDefinitionHandler(PreferenceManager preferenceManager) { | |||
| location = computeDefinitionNavigation(unit, position.getPosition().getLine(), | |||
| position.getPosition().getCharacter(), monitor); | |||
| } | |||
| return location == null ? null : Arrays.asList(location); | |||
| return location == null ? new ArrayList<Location>() : Arrays.asList(location); | |||
|
@fbricon updated the PR :) apologies for the delay! |
|
Can you please sign-off your commit so I can merge it? |
|
@fbricon I think something is messed up with the authentication system :( First it told me that my email doesn't match (as I created the last commit from GitHub UI). So I found this: Which indicated that I should create it from command line instead. I did that and force pushed, but it is still failing. Here is my commit info: It has the right email: But still I get an error message from the CLA site: Is it a bug in the email parser? notice it says |
|
I'm not sure. Reading https://bugs.eclipse.org/bugs/show_bug.cgi?id=498340, it seems this should work for the web ui. |
|
... then you should see something similar to "Signed-off-by: [email protected]" in the commit message. |
Signed-off-by: Omar Tawfik <[email protected]>
|
@fbricon that solved it! |
|
Thanks @OmarTawfik ! |
When testing an instance of the server running locally in VSCode, I noticed quite a few error messages like the following from the node client:
I tracked it down to this handler. Making this update to return an empty list instead, which makes the VSCode client happy. I've updated the tests.