jump to definition on break/continue

[snjeza]

Fixes redhat-developer/vscode-java#1145

Signed-off-by: Snjezana Peco [email protected]

[fbricon]

If I open https://github.com/eclipse/eclipse.jdt.ls/pull/1281/files#diff-cf0a7da25e0081c3469ee576216a62ad in vscode, try to Go to Definition on either a break or continue keyword, without label, I can see the ranges returned cover multiple lines and nothing happens. We should jump to the start of the matching while loop.
It works for labels though.

[snjeza]

I can see the ranges returned cover multiple lines and nothing happens

[fbricon]

I tried vscode insiders

[snjeza]

I think, this is a bug in VS Code Insiders.

VS Code 1.40.1:

VS Code sends the document/definition command.

VS Code Insiders 1.41

VS Code Insiders sends the document/definition and document/references commands,

[fbricon]

@snjeza see if you can reproduce with typescript, if you do then please open an issue upstream

[snjeza]

see if you can reproduce with typescript, if you do then please open an issue upstream

I can reproduce the issue with typescript. I have created microsoft/vscode#85403

[fbricon]

Thanks, I'll merge the PR then since it works with a proper version of vscode