Add buildship offline mode preference #1308
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The offline flag is only used during project import. After import, if you toggle it, it has no effect to the project (try messing with dependency resolution) |
fbricon
requested changes
Dec 18, 2019
@fbricon Done. |
|
This doesn't fix the issue. Buildship's offline status should react to preference changes sent by the client |
fbricon
requested changes
Dec 19, 2019
| @@ -703,6 +713,19 @@ public Preferences setImportGradleEnabled(boolean enabled) { | |||
| return this; | |||
| } | |||
|
|
|||
| @SuppressWarnings("restriction") | |||
| public Preferences setImportGradleOfflineEnabled(boolean enabled) { | |||
There was a problem hiding this comment.
I'd rather prefer we decouple preferences from Gradle (or any build system). We should have preference listeners for that
Signed-off-by: Snjezana Peco <[email protected]>
|
@fbricon I have updated the PR. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#1157
Requires redhat-developer/vscode-java#1199
Signed-off-by: Snjezana Peco [email protected]