Add 'Generate constructor' option to 'Show Fixes' options for fields

[snjeza]

Fixes redhat-developer/vscode-java#1358

Signed-off-by: Snjezana Peco [email protected]

[fbricon]

we're basically recomputing the actions a 2nd time, seems suboptimal. Couldn't we just copy the ones we have already and change their kind?

[snjeza]

Fixed.

[fbricon]

Starting from

public class Foo {

	private String name;

}

After applying the code action to generate the constructor, I get:

public class Foo {

	private String name;

	public Foo(String name) {
		this.name = name;
	}

}

So far so good, but then, the Generate Constructor... code actions is still available on name. And for sure, lets you generate a duplicate constructor. In IntelliJ IDEA, the Generate constructor quick fix is no longer available, after generating the constructor.

[snjeza]

So far so good, but then, the Generate Constructor... code actions is still available. And for sure, lets you generate a duplicate constructor. In IntelliJ IDEA, the Generate constructor quick fix is no longer available, after generating the constructor.

The code to compute constructors is in GenerateConstructorsHandler, so we can fix it

[snjeza]

@fbricon I have updated the PR.

[snjeza]

In IntelliJ IDEA, the Generate constructor quick fix is no longer available, after generating the constructor.
The code to compute constructors is in GenerateConstructorsHandler, so we can fix it

IntelliJ IDEA creates only one constructor when existing more fields. Eclipse/Java LS creates multiple constructors.