add threshold for organizing imports with the asterisk (*) wildcard character

[snjeza]

See redhat-developer/vscode-java#964
see redhat-developer/vscode-java#1374

Signed-off-by: Snjezana Peco [email protected]

[fbricon]

Tested on vscode-java, setting

"java.import.ondemandthreshold": 2,
"java.import.staticondemandthreshold": 2,

No star imports are added with:

package test1;

import static java.lang.Math.abs;
import static java.lang.Math.pow;
import static java.lang.Math.sqrt;

import java.util.ArrayList;
import java.util.HashMap;
import java.util.List;
import java.util.Map;


public class E {
    
    List<String> list = new ArrayList<>();
    Map<String, String> map = new HashMap<String, String>();
    public static void main(String[] args) {
        double d1 = sqrt(4);
        double d2 = pow(d1, abs(2));
        System.err.println(d2);
    }
}

[fbricon]

Prefs names need to be changed, but more importantly, feature should work. It just doesn't right now.

[fbricon]

Also https://github.com/eclipse/eclipse.jdt.ls/blob/1cc049e2d19bba5e31f94032c4851fd0a5840bea/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/contentassist/TypeProposalUtils.java#L166-L169

needs to be replaced with:

Preferences preferences = JavaLanguageServerPlugin.getPreferencesManager() == null ? new Preferences() : JavaLanguageServerPlugin.getPreferencesManager().getPreferences();
rewrite.setImportOrder(preferences.getImportOrder());
rewrite.setOnDemandImportThreshold(preferences.getImportOnDemandThreshold());
rewrite.setStaticOnDemandImportThreshold(preferences.getStaticImportOnDemandThreshold());

(IMPORTS_THRESHOLD can be removed)

Which will need new tests for checking completion generates star imports.

[fbricon]

test this please

[snjeza]

@fbricon I have updated the PR.

[snjeza]

test this please

[snjeza]

test this please

[snjeza]

@fbricon I have updated the PR.

[fbricon]

Thanks @snjeza!