-
Notifications
You must be signed in to change notification settings - Fork 408
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Enable code completion for syntax server #1463
Enable code completion for syntax server #1463
Conversation
Signed-off-by: Jinbo Wang <[email protected]>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
....core/src/org/eclipse/jdt/ls/core/internal/syntaxserver/ModelBasedSearchableEnvironment.java
Outdated
Show resolved
Hide resolved
Signed-off-by: Jinbo Wang <[email protected]>
Still have the same issue, testing vscode-insiders: Completion response[Trace - 2:01:02 PM] Sending request 'textDocument/completion - (60)'. Params: { "textDocument": { "uri": "file:///Users/fbricon/Dev/quarkus-projects/totoototo/src/test/java/foo/bar/action/Tester.java" }, "position": { "line": 22, "character": 12 }, "context": { "triggerKind": 1 } }[Trace - 2:01:02 PM] Received notification 'window/logMessage'. [Info - 2:01:02 PM] 8-Jun-2020 2:01:02 PM >> document/completion [Info - 2:01:02 PM] 8-Jun-2020 2:01:02 PM Search engine disabled, searching directly. [Info - 2:01:02 PM] 8-Jun-2020 2:01:02 PM Completion request completed [Trace - 2:01:02 PM] Sending request 'completionItem/resolve - (61)'. [Trace - 2:01:02 PM] Received notification 'window/logMessage'. [Info - 2:01:02 PM] 8-Jun-2020 2:01:02 PM >> document/resolveCompletionItem sortText has lower value, so should be displayed 1st. Maybe a vscode-insiders issue. |
When trying with String, sort works as expected (still with a lower sortText value). Completion response[Trace - 2:06:34 PM] Sending request 'textDocument/completion - (73)'. Params: { "textDocument": { "uri": "file:///Users/fbricon/Dev/quarkus-projects/totoototo/src/test/java/foo/bar/action/Tester.java" }, "position": { "line": 22, "character": 14 }, "context": { "triggerKind": 1 } }[Trace - 2:06:34 PM] Received notification 'window/logMessage'. [Info - 2:06:34 PM] 8-Jun-2020 2:06:34 PM >> document/completion [Info - 2:06:34 PM] 8-Jun-2020 2:06:34 PM Search engine disabled, searching directly. [Info - 2:06:34 PM] 8-Jun-2020 2:06:34 PM Completion request completed [Trace - 2:06:34 PM] Sending request 'completionItem/resolve - (74)'. [Trace - 2:06:34 PM] Received notification 'window/logMessage'. [Info - 2:06:34 PM] 8-Jun-2020 2:06:34 PM >> document/resolveCompletionItem |
Works fine with the LemMinX codebase. There's something fishy with my test project, but I don't think it's related to this PR. I'm fine with merging it. |
Thanks @testforstephen! |
Signed-off-by: Jinbo Wang [email protected]