Support annotations in semantic highlighting #1477
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
requested changes
Jun 11, 2020
org.eclipse.jdt.ls.tests/.gitignore
Outdated
| @@ -0,0 +1,3 @@ | |||
| # temp files generated when running test projects | |||
There was a problem hiding this comment.
this should not be necessary, this indicates the tests are changing source directories, which is bad.
There was a problem hiding this comment.
so we want to keep the .gitignore unchanged, as this is our canary telling us the tests are bad
There was a problem hiding this comment.
OK. I just let the canary go this time 😄
Signed-off-by: Yan Zhang <[email protected]>
Eskibear
force-pushed
the
semantic-annotation
branch
from
1078348 to
9e72308
Compare
fbricon
changed the title
|
Thanks @Eskibear |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
part of redhat-developer/vscode-java#1488