Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Avoid unnecessary Gradle re-synch on restart #1485

Merged
merged 1 commit into from
Jun 17, 2020

Conversation

fbricon
Copy link
Contributor

@fbricon fbricon commented Jun 17, 2020

Non-Java Gradle projects would automatically trigger a costly Gradle sync.
This change allows to reopen the spring-boot project and get diagnostics back
in less than 20sec, when combined with #1484.

@fbricon fbricon requested a review from snjeza June 17, 2020 13:19
@fbricon
Copy link
Contributor Author

fbricon commented Jun 17, 2020

@jdneo @testforstephen @Eskibear you should definitely try this along with #1484 ;-)

@fbricon fbricon force-pushed the optimizeGradleImports branch from c0bdf6f to 75af489 Compare June 17, 2020 14:30
@testforstephen
Copy link
Contributor

yeah, I'm very interested in giving it a try.

@fbricon fbricon force-pushed the optimizeGradleImports branch from 75af489 to 236601c Compare June 17, 2020 15:46
@fbricon fbricon force-pushed the optimizeGradleImports branch from 236601c to e8bdde5 Compare June 17, 2020 16:45
@fbricon fbricon added this to the Mid June 2020 milestone Jun 17, 2020
@fbricon fbricon merged commit 9c6f725 into eclipse-jdtls:master Jun 17, 2020
@fbricon fbricon deleted the optimizeGradleImports branch June 17, 2020 17:44
@Eskibear
Copy link
Contributor

Tried with the maven-based spring-petclinic, it looks good. (~10s to receive response of initialize, then <10s after LS was intialized.)

@testforstephen
Copy link
Contributor

Wow!!!!!!!! Supersonic!

When reopening springboot framework code, the load time from 3 mins to ~20 seconds. Amazing. Kudos @fbricon

@fbricon
Copy link
Contributor Author

fbricon commented Jun 18, 2020

Wow!!!!!!!! Supersonic!

When reopening springboot framework code, the load time from 3 mins to ~20 seconds. Amazing. Kudos @fbricon

This is actually @snjeza 's find: #1484 (comment), she deserves the credit!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants