Hide inline variable commands when no reference found #1573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
CsCherrYY
force-pushed
the
inlineVariableFix
branch
from
8cbd159 to
def7020
Compare
Signed-off-by: schenqce <[email protected]>
CsCherrYY
force-pushed
the
inlineVariableFix
branch
from
def7020 to
f344986
Compare
| @@ -346,7 +346,7 @@ private boolean getInlineProposal(IInvocationContext context, ASTNode node, Coll | |||
| // Inline Local Variable | |||
| if (binding.getJavaElement() instanceof ILocalVariable && RefactoringAvailabilityTesterCore.isInlineTempAvailable((ILocalVariable) binding.getJavaElement())) { | |||
| InlineTempRefactoring refactoring= new InlineTempRefactoring((VariableDeclaration) decl); | |||
| if (refactoring.checkInitialConditions(new NullProgressMonitor()).isOK()) { | |||
| if (refactoring.checkInitialConditions(new NullProgressMonitor()).isOK() && refactoring.getReferences().length > 0) { | |||
There was a problem hiding this comment.
Since refactoring.checkInitialialConditions() will also invoke refactoring.getReferences() and cache the result to a field. The second call refactoring.getReferences() will just return the previous result, and no extra cost.
|
thanks @CsCherrYY |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Just hide meanless refactor commands when a variable has no reference. The following gifs show the effect of this PR.
Before:
After: