Fix method ref CompletionItemKind

[0dinD]

Fixes redhat-developer/vscode-java#1661

[0dinD]

My change has caused a test failure, since there was an assertion where the CompletionItemKind of a static method import was expected to be CompletionItemKind.Module. This makes no sense to me, since I thought CompletionProposal.METHOD_NAME_REFERENCE was only for method references, not method imports, seeing as there is also CompletionProposal.METHOD_IMPORT. But it seems like neither of the cases produce a CompletionProposal.METHOD_IMPORT, and instead they both get CompletionProposal.METHOD_NAME_REFERENCE, for whatever reason. I suspect this is why the decision was made to give method references CompletionItemKind.Module in the first place.

However, I still don't think CompletionItemKind.Module makes any sense even for method imports, since they are also still methods, not modules/packages. It's also inconsistent with what CompletionItemKind other type members are given: classes, fields, enums etc. are given their respective CompletionItemKind, not CompletionItemKind.Module.

After updating the test case, I saw another test failure on the CI server, but this one seems very random as I don't think my changes affected anything to do with that test. I also ran the same test locally, and found that it passes with no failures.

[snjeza]

test this please

[fbricon]

Thanks @0dinD!