Hide inline constant commands when no reference found #1575
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: schenqce <[email protected]>
Signed-off-by: schenqce <[email protected]>
|
Thanks @CsCherrYY! |
| for (Change refactoringChange : refactoringChanges) { | ||
| referenceCount += ((CompilationUnitChange)refactoringChange).getChangeGroups().length; | ||
| } | ||
| if (referenceCount <= 1 && refactoring.isDeclarationSelected()) { |
There was a problem hiding this comment.
@CsCherrYY Below is a corner case. The change group will be 2 (1 for remove imports, 1 for remove the declaration) even though no references are using the constant field. The "Inline" menu won't be hidden.
import java.util.HashMap;
import java.util.Map;
public class Hello {
public static final Map map = new HashMap<>();
}There was a problem hiding this comment.
@testforstephen Thanks a lot for kind reminding, I would like to implement this clearer and avoid corner case like this by changing some APIs in jdt later.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
hide meaningless refactor commands when a constant has no reference. The following gifs show the effect of this PR.
Before:
After: