Support inferSelection when extract to field #1619
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can one of the admins verify this patch? |
|
add to whitelist |
fbricon
reviewed
Nov 27, 2020
org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/preferences/ClientPreferences.java
Outdated
Show resolved
Hide resolved
|
test this please |
...eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/InferSelectionHandler.java
Outdated
Show resolved
Hide resolved
...clipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/handlers/GetRefactorEditHandler.java
Outdated
Show resolved
Hide resolved
|
@CsCherrYY You have to resolve the conflicts first. |
Sure. I'll do it. |
Signed-off-by: Shi Chen <[email protected]>
CsCherrYY
force-pushed
the
extractField
branch
from
313d473 to
1b72db8
Compare
|
test this please |
Signed-off-by: Shi Chen <[email protected]>
testforstephen
approved these changes
Dec 2, 2020
mfussenegger
added a commit
to mfussenegger/nvim-jdtls
that referenced
this pull request
Dec 2, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relates to redhat-developer/vscode-java#1721
Add support to
extractFieldIninferSelectionSupportcapability, making it possible to infer selections if there is no selection range when extract to field.Also add a field
paramsinSelectionInfoto support send scope information from the server to the client.To keep the consistency, also rename
isExtractMethodInferSelectionSupporttoisExtractMethodInferSelectionSupportedand change some invocation about extracting method.Signed-off-by: Shi Chen [email protected]