Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support to INFO log level #1623

Merged
merged 1 commit into from
Dec 4, 2020
Merged

Conversation

drungrin
Copy link
Contributor

@drungrin drungrin commented Dec 2, 2020

There is no way get INFO logging level messages besides setting the log level to ALL.

This PR allows that. In my case, I need to listen to the ">> build jobs finished" and others.

@eclipse-ls-bot
Copy link

Can one of the admins verify this patch?

Copy link
Contributor

@rgrunber rgrunber left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The change seems fine to me. I agree that for those that set -Dlog.level=INFO and only get WARNING/ERROR messages due to the fallthrough, it would be very confusing.

Signed-off-by: Michel Moreira <[email protected]>
@testforstephen testforstephen merged commit deb2380 into eclipse-jdtls:master Dec 4, 2020
@testforstephen
Copy link
Contributor

@drungrin thanks.

@testforstephen testforstephen added this to the Mid December 2020 milestone Dec 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants