show generate toString()/hashCode() and equals() quick fixes on demand #2213
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
test this please |
Signed-off-by: Shi Chen <[email protected]>
CsCherrYY
force-pushed
the
cs-quickfix-ondemand
branch
from
c4be6ba to
a04edce
Compare
|
test this please |
rgrunber
reviewed
Sep 15, 2022
| @@ -177,4 +177,23 @@ public void testGenerateToStringQuickAssist_emptyFields() throws JavaModelExcept | |||
| quickAssistActions = CodeActionHandlerTest.findActions(codeActions, JavaCodeActionKind.QUICK_ASSIST); | |||
| Assert.assertFalse(CodeActionHandlerTest.commandExists(quickAssistActions, CodeActionHandler.COMMAND_ID_APPLY_EDIT, ActionMessages.GenerateToStringAction_label)); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testGenerateToStringQuickAssistExists() throws JavaModelException { | |||
There was a problem hiding this comment.
For this method and the one below. Instead of calling them testGenerateToStringQuickAssistExists, testHashCodeEqualsQuickAssistExists , I would call them testNoGenerateToStringQuickAssist & testNoHashCodeEqualsQuickAssist .
Basically, the current name implies that the quick-assist should exist, but I know what you mean is that the method exists so the quick-assist shouldn't. It just might be confusing with the current name.
There was a problem hiding this comment.
Yeah, Let's make them clear.
Signed-off-by: Shi Chen <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Signed-off-by: Shi Chen [email protected]
This PR will detect the methods of the current type, and choose which quick fix to show.If the current type has corresponding:
Please note that this change will not affect "Source Action" in the right click menu, the "Source Action" part will always show them in case of the user wants to override the methods anyway.