Keep the temp init scripts on disk

[jdneo]

• The temp files will not be deleted on JVM exist, since it will cause buildship fail when get Eclipse project instance after the server restarts.
• Cache the temp files for each session, to make sure there will not be too many temp files generated when reloading projects.

related with redhat-developer/vscode-java#2692

Signed-off-by: Sheng Chen [email protected]

[jdneo]

test this please

[jdneo]

test this please

[jdneo]

@rgrunber Not sure why the test case is failing. Could we include this change in this release? It makes sure the gradle project reloading will not fail due to file not exists.

[testforstephen]

https://ci.eclipse.org/ls/job/jdt-ls-pr/3616/testReport/junit/org.eclipse.jdt.ls.core.internal.handlers/WorkspaceDiagnosticsHandlerTest/testMissingNatures/

This should be a random failure because it also fails in another PR #2248 (CI Job)

[testforstephen]

test this please

[testforstephen]

https://github.com/eclipse/eclipse.jdt.ls/blob/d65385a0d09df1c3a904a6644efe1b0c1a7860d0/org.eclipse.jdt.ls.core/src/org/eclipse/jdt/ls/core/internal/managers/GradleProjectImporter.java#L631-L640

A different approach I was thinking of is that we could create a fixed temporary file for an identical scriptPath. For example, you could calculate the md5 value of the scriptPath and create a file in the tmp directory using md5 as the filename. This way you avoid creating many temporary files for the init scripts, and you don't need to delete them as well.

[rgrunber]

I think it makes sense to accept this PR as-is to at least improve the situation prior to releasing. From there we can further improve this.

doing a checksum on the content of the init script(s) would definitely avoid creating duplicates.

[jdneo]

Sounds good. I can do a checksum for the file content, then it will only generate new files when the content of the script is changed.

Meanwhile, checksum can be used to check the integrity of the script for security concern