Renaming or creating a java file requires restart #486
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fbricon
reviewed
Dec 7, 2017
| private ICompilationUnit createCompilationUnit(ICompilationUnit unit) { | ||
| try { | ||
| unit.getResource().refreshLocal(IResource.DEPTH_ONE, new NullProgressMonitor()); | ||
| if (unit.getResource().exists()) { |
There was a problem hiding this comment.
shouldn't we check the resource exists BEFORE refreshing it?
There was a problem hiding this comment.
this method is largely similar to the block you modified in DocumentLifeCycleHandler.handleOpen, yet the conditions are different. Here the resource needs to exists, in handleOpen, it must not be accessible (doesn't exist). Seems dubious. Both places should probably be refactored to call the same logic
There was a problem hiding this comment.
The resource must exist after refreshing.
|
@snjeza can we have some integration tests here or is it too complex? |
|
@fbricon I will try to create a test. |
Signed-off-by: Snjezana Peco <[email protected]>
|
@fbricon I have updated the PR. |
This was referenced May 8, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes redhat-developer/vscode-java#380
Signed-off-by: Snjezana Peco [email protected]