Fix cache result of external grammar info #696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
This PR uses the (none used referencedExternalGrammarInitialized flag) to avoid computing the information if DOM document has an external grammar or not. No need to write test, because we have test for that. |
fbricon
reviewed
May 13, 2020
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/DOMDocument.java
Outdated
Show resolved
Hide resolved
org.eclipse.lemminx/src/main/java/org/eclipse/lemminx/dom/DOMDocument.java
Outdated
Show resolved
Hide resolved
angelozerr
force-pushed
the
cache-referencedExternalGrammarInitialized
branch
from
6891a16 to
1ddd0b4
Compare
Signed-off-by: azerr <[email protected]>
xorye
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cache result of external grammar info.
Signed-off-by: azerr [email protected]