[layout] introduced 'interactive' layout #36
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
spoenemann
reviewed
Sep 5, 2019
|
|
||
| Map<T, String> element2id = newHashMap | ||
| Map<String, T> id2element = newHashMap | ||
| Set<String> otherIds = newHashSet |
There was a problem hiding this comment.
It seems you have reverted my changes c5d5b14#diff-792329e50cbbdd3a4b69713fb7e205fb
Was this on purpose?
| @@ -514,7 +516,8 @@ protected void handle(OpenAction action) { | |||
| * Called when a {@link LayoutAction} is received. | |||
| */ | |||
| protected void handle(LayoutAction action) { | |||
| if (getServerLayoutKind(getModel()) != ServerLayoutKind.NONE) { | |||
| ServerLayoutKind layoutKind = getServerLayoutKind(currentRoot); | |||
| if (layoutKind != ServerLayoutKind.AUTOMATIC && layoutKind != ServerLayoutKind.NONE) { | |||
There was a problem hiding this comment.
We should also process such actions when the layout kind is AUTOMATIC.
| * is close to a partial layout. | ||
| * The layout information must be stored in the model and will be overwritten on layout. | ||
| */ | ||
| INTERACTIVE, |
There was a problem hiding this comment.
This value is not used anywhere in the framework. How would an application use it?
JanKoehnlein
force-pushed
the
jk/interactive
branch
from
217b5e1 to
0e60885
Compare
- added ServerLayoutKind.INTERACTIVE and handle it in DefaultDiagramServer - allow to forward causing action to the layout, e.g. to fully layout when the user wants taht Fixes #35 [generator] Fixed IdCache and example
JanKoehnlein
force-pushed
the
jk/interactive
branch
from
0e60885 to
522fe6d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes [layout] add an interactive layout option #35