Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add Theia implementation for Sprotty context menu #47

Merged
merged 5 commits into from
Dec 31, 2019
Merged

Add Theia implementation for Sprotty context menu #47

merged 5 commits into from
Dec 31, 2019

Conversation

planger
Copy link
Contributor

@planger planger commented Nov 5, 2019 •
edited
Loading

See eclipse-sprotty/sprotty#139
This change requires eclipse-sprotty/sprotty#144 -- build has to be retriggered once eclipse-sprotty/sprotty#144 is merged, otherwise CI will keep failing.

@gitpod-io
Copy link

gitpod-io bot commented Nov 5, 2019 •
edited
Loading

@planger planger mentioned this pull request Nov 5, 2019
Merged
JanKoehnlein
JanKoehnlein reviewed Nov 22, 2019
View reviewed changes
Copy link
Contributor

@JanKoehnlein JanKoehnlein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you have an example how to use this somewhere

src/sprotty/theia-sprotty-context-menu-service.ts Outdated
}
}

class GlspCommandHandler implements CommandHandler {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SprottyCommandHandler?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that... I'll rename it.

@planger
Copy link
Contributor Author

planger commented Nov 22, 2019

Do you have an example how to use this somewhere

Please see eclipse-sprotty/sprotty#144 (comment)

@planger planger requested a review from JanKoehnlein November 22, 2019 14:59
@planger planger merged commit fec87e7 into eclipse-sprotty:master Dec 31, 2019
@planger planger deleted the issues/139 branch December 31, 2019 15:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JanKoehnlein JanKoehnlein Awaiting requested review from JanKoehnlein

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@planger @JanKoehnlein