Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(exportExcel): Generate and save excel to file system, Download generated file with token #1477

Merged
merged 2 commits into from
Apr 28, 2022
Merged

feat(exportExcel): Generate and save excel to file system, Download generated file with token #1477

merged 2 commits into from
Apr 28, 2022

Conversation

JaideepPalit
Copy link
Contributor

Generate and save excel to file system, Download generated file with token.

closes: #1475

How To Test?

How should these changes be tested by the reviewer?
Have you implemented any additional tests? - No

Checklist

Must:

  • All related issues are referenced in commit messages and in PR

Signed-off-by: Jaideep Palit [email protected]

@smrutis1
Copy link
Contributor

(from discussion):

  • User will get an email once project spreadsheet export(i.e in /tmp) is completed with the download link.
  • set this send.project.spreadsheet.export.to.mail.enabled = true in sw360.properties file to enable this feature .

@ag4ums
Copy link
Contributor

ag4ums commented Mar 30, 2022

report generation is breaking when multiple users tries to generate report

@smrutis1 smrutis1 force-pushed the feat/optimizeExport branch 2 times, most recently from ecbc418 to 4acf7dc Compare April 19, 2022 07:23
@smrutis1 smrutis1 added needs code review needs general test This is general testing, meaning that there is no org specific issue to check for and removed WIP work in progress do not merge - нет! labels Apr 20, 2022
@smrutis1
Copy link
Contributor

To reduce the size more you can remove many columns

| project name | version | group | project type | project tag | clearingState | name | release: version | component type | clearing state | ECC information: eccStatus | ECC information: ECCN | ECC information: assessorDepartment | ECC information: assessmentDate |

@Marco-Wagner
Copy link

Yes only the mentioned colums are most important for a minimum set of an excel file.
The rest of the columns can be removed.
In my test it has reduced the size massivly.

@Marco-Wagner
Copy link

PS: I want to mention here additionally that in my test saving the exported excel file from SW360 production instance over Microsoft Excel reduces the excel file to 10% of the file size (without column change)

@Marco-Wagner
Copy link

Perhaps some excel compression option missing? :)

akapti
akapti requested changes Apr 22, 2022
View reviewed changes
Copy link
Contributor

@akapti akapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

reviewed the code. suggested some changes.

backend/src-common/src/main/java/org/eclipse/sw360/mail/MailUtil.java Outdated Show resolved Hide resolved
libraries/exporters/src/main/java/org/eclipse/sw360/exporter/ProjectExporter.java Show resolved Hide resolved
libraries/exporters/src/main/java/org/eclipse/sw360/exporter/ProjectExporter.java Outdated Show resolved Hide resolved
libraries/exporters/src/main/java/org/eclipse/sw360/exporter/ExcelExporter.java Outdated Show resolved Hide resolved
...d/sw360-portlet/src/main/java/org/eclipse/sw360/portal/portlets/projects/ProjectPortlet.java Outdated Show resolved Hide resolved
...d/sw360-portlet/src/main/java/org/eclipse/sw360/portal/portlets/projects/ProjectPortlet.java Outdated Show resolved Hide resolved
@smrutis1 smrutis1 force-pushed the feat/optimizeExport branch from 4acf7dc to 6dcc7b0 Compare April 25, 2022 06:33
@smrutis1
Copy link
Contributor

@akapti Thanks for review. Have incorporated the changes.

akapti
akapti approved these changes Apr 25, 2022
View reviewed changes
Copy link
Contributor

@akapti akapti left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code looks good to me.
Approved.
Tested by: @ag4ums

@akapti akapti added ready ready to merge and removed needs code review needs general test This is general testing, meaning that there is no org specific issue to check for labels Apr 25, 2022
@smrutis1 smrutis1 force-pushed the feat/optimizeExport branch from 6dcc7b0 to 84950d7 Compare April 26, 2022 06:35
Jaideep Palit and others added 2 commits April 27, 2022 13:27
@smrutis1 smrutis1 force-pushed the feat/optimizeExport branch from 84950d7 to 26226fb Compare April 27, 2022 08:39
@smrutis1
Copy link
Contributor

Resolved merge conflicts

@KoukiHama KoukiHama assigned KoukiHama and unassigned KoukiHama Apr 27, 2022
@ag4ums ag4ums merged commit c235c95 into eclipse-sw360:master Apr 28, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@akapti akapti akapti approved these changes

Assignees
No one assigned
Labels
ready ready to merge
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Timeout error of Export excel and Rest api when data is too large
6 participants
@JaideepPalit @smrutis1 @ag4ums @Marco-Wagner @akapti @KoukiHama