Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issues with the WT codes #161

Closed
FatimaPillosu opened this issue Mar 24, 2021 · 2 comments
Closed

Issues with the WT codes #161

FatimaPillosu opened this issue Mar 24, 2021 · 2 comments
Assignees
Labels
bug Something isn't working priority 1 STOP. This is preventing EVERYONE from using the software.

Comments

@FatimaPillosu
Copy link
Contributor

FatimaPillosu commented Mar 24, 2021

Hi @onyb,
there is a problem with the WT codes that @esti, @AugustinVintzileos and @ATimHewson found out yesterday.
As you create the DT, the codes of the WTs change in a funny way. If I have the root with the code 00000, and I split it into two nodes with the code 10000 and 20000, the code for the root changes to 20000. This should not happen.
This problem happens at every node, not only the root. Could you please check this issue? I don't know how this might be influencing the creation of the WTs so I'll put this issue as priority 1.
Cheers,
Fatima

@FatimaPillosu FatimaPillosu added bug Something isn't working priority 1 STOP. This is preventing EVERYONE from using the software. labels Mar 24, 2021
@onyb
Copy link
Contributor

onyb commented Mar 31, 2021

Update: This is indeed a bug that I managed to trace to the construction of the decision tree. It's unlikely that this is a regression. I am coming up with an alternative algorithm (using recursion).

According to my assessment, the bug is limited to mislabeled non-leaf nodes and doesn't impact the correctness of mapping functions. I implemented an exhaustive unit-test to ensure the tree construction doesn't break after the proposed fix.

@onyb
Copy link
Contributor

onyb commented Apr 6, 2021

Fixed in v0.24.0.

@onyb onyb closed this as completed Apr 6, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority 1 STOP. This is preventing EVERYONE from using the software.
Projects
None yet
Development

No branches or pull requests

2 participants