Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CRAN warnings with g++-14 #91

Closed
eddelbuettel opened this issue Jul 4, 2024 · 2 comments · Fixed by #92
Closed

CRAN warnings with g++-14 #91

eddelbuettel opened this issue Jul 4, 2024 · 2 comments · Fixed by #92

Comments

@eddelbuettel
Copy link
Owner

Via email from CRAN:

Dear maintainer,

Please see the problems shown on
https://cran.r-project.org/web/checks/check_results_RcppSimdJson.html.

Please correct before 2024-08-03 to safely retain your package on CRAN.

This is primarily about the compiler C++ warnings
shown in the fedora-gcc results. These are from g++ 14.x
which was released a couple of months ago.

The CRAN Team

which shows both via https://cran.r-project.org/web/checks/check_results_RcppSimdJson.html directly and the 'gcc12' link

  • checking whether package ‘RcppSimdJson’ can be installed ... [241s/251s] WARNING
    Found the following significant warnings:
    ../inst/include/RcppSimdJson/deserialize/../../simdjson.h:14229:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/RcppSimdJson/deserialize/../../simdjson.h:14230:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/RcppSimdJson/deserialize/../../simdjson.h:14232:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/RcppSimdJson/deserialize/../../simdjson.h:16393:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/RcppSimdJson/deserialize/../../simdjson.h:16394:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/RcppSimdJson/deserialize/../../simdjson.h:16396:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/RcppSimdJson/deserialize/../../simdjson.h:20872:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/RcppSimdJson/deserialize/../../simdjson.h:20873:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/Rc
    ppSimdJson/deserialize/../../simdjson.h:20875:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/RcppSimdJson/deserialize/Type_Doctor.hpp:43:65: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:14229:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:14230:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:14232:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:16393:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:16394:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:16396:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:20872:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:20873:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    ../inst/include/simdjson.h:20875:32: warning: template-id not allowed for constructor in C++20 [-Wtemplate-id-cdtor]
    See ‘/data/gannet/ripley/R/packages/tests-devel/RcppSimdJson.Rcheck/00install.out’ for details.
  • used C++ compiler: ‘g++-14 (GCC) 14.1.0’

Any sage advice here @lemire ? I guess I could hardwire C++17 as a standard in the short-term but I presume 'eventually' we need to make a change.

Now, it could well be that the change is already made upstream -- I have not sync'ed in a while. If so just let me know....

Dirk (in Europe for a few more days)

@lemire
Copy link
Collaborator

lemire commented Jul 4, 2024

See #92 where I propose a version bump.

The simdjson library is kept up-to-date and tested with all major compilers with almost all possible flags, including C++20.

@eddelbuettel
Copy link
Owner Author

You rock, and thank you from Athens airport.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants