Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refine the protocol properties of GPS Device #29

Closed
cloudxxx8 opened this issue Jul 11, 2019 · 1 comment
Closed

Refine the protocol properties of GPS Device #29

cloudxxx8 opened this issue Jul 11, 2019 · 1 comment

Comments

@cloudxxx8
Copy link

Currently in configuration.toml, the protocol properties are defined as follows:
https://github.com/edgexfoundry-holding/device-gps/blob/master/cmd/res/configuration.toml#L64-L67

However, the Address and Port are not used in the driver. We only need to define the ProtocolProperties driver needs to connect to the real device, for example:

  [DeviceList.Protocols]
    [DeviceList.Protocols.gps]
      Path = "/dev/ttyUSB0"

In this case, the hard code path of GPS Device could be moved into the ProtocolProperties.

@cloudxxx8
Copy link
Author

In README.md:

The default device service behavior is to read from the mock data file. This needs to be changed. Edit line 91 in driver/gpsdevice.go, changing gps_output_test.txt to /dev/ttyUSB0.

However, it is not in line 91 anymore, and it is in line 62. Thus, we had better avoid hard code the path.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants