Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Keyboard shortcuts sometimes don't work #1197

Closed
sukiletxe opened this issue Oct 3, 2020 · 12 comments
Closed

Keyboard shortcuts sometimes don't work #1197

sukiletxe opened this issue Oct 3, 2020 · 12 comments

Comments

@sukiletxe
Copy link

I cannot provide steps to reproduce as it doesn't always happen, but specifically ctrl+pgup and ctrl+pgdn sometimes don't jump to next and previous chapters.

@lpintes
Copy link

lpintes commented Oct 4, 2020

I can confirm this. And I would say that not sometimes, but quite often.

@lpintes
Copy link

lpintes commented Oct 4, 2020

Currently I am running the latest version from Git and I am trying to read the following book:

Building Microservices with Go
Nic Jackson
Published on 07/27/2017
Publisher: Packt Publishing

@danielweck
Copy link
Member

Thank you for reporting this. Could you please specify your operating system (Windows, Linux or MacOS). Could you also indicate whether or not you are using Thorium with a screen reader (and if so, which one). Most importantly, which version of Thorium are you using? (on GitHub there are the official "stable" releases, and the "nightly" automated builds)

@lpintes
Copy link

lpintes commented Oct 4, 2020

Windows 10, version 2004
I am running NVDA Alpha, updated regularly.
I built Thorium from source, so it is the latest version from master.

@danielweck
Copy link
Member

Okay thank you. The master branch corresponds to the latest stable release, currently deployed via the Windows Store. The develop branch contains the most up to date code. To save you building the application yourself, you may downloaded the automatically-generated executable from https://github.com/edrlab/thorium-reader/releases/tag/latest-windows

@lpintes
Copy link

lpintes commented Oct 4, 2020

Oh sorry. I tested against develop branch.
I cloned and tested, and didn't notice that a develop branch is a default one.

@m-c-g
Copy link

m-c-g commented Oct 5, 2020

I've found a reproducible case.
This is on a Mac, Mojave, with the compiled reader version from the current DMG.

Open a document in full screen, accidentally hit ctrl-s, the arrow keys no longer work.

You have to leave full screen (why doesn't esc work for this?) and realize you have
opened the settings panel and close it.

If there are modalities in the interface you need visual feedback indicating them and
how to get back where you were.

The only documentation for the keyboard functions I find is the settings panel from
the main screen, which you can't find from the reader screen. It doesn't give any
explanation of how the interface works other than the command that gets issued.
Additionally, the focus search and focus tool-bar keystrokes don't appear to function.

Thorium renders documents beautifully. With a better interface and documentation it
could easily become a multiplatform standard.

@danielweck
Copy link
Member

Great report, thank you.

@sukiletxe
Copy link
Author

However that's not always the case. Sometimes they don't work, you insist and then they do work. Happened on stable, happens also on Nightly. Windows 10, NVDA screen reader.

@danielweck
Copy link
Member

Comment from NNELS (Danny Faris @BCLibCoop ):

We have noticed that Thorium will ocasionally become unresponsive after switching away from the window to another application, then switching back. This only seems to be an issue with the keyboard and screen reader, visually the interface continues to work fine with the mouse.

@gautierchomel
Copy link
Member

I reproduce the error with NVDA and windows 10 : when on fullscreen CTRL + Page Down does not seem to work.
However this does not affects all books. An old epub2 is affected but not a recent epub3 (searching for a public reference).
The difference between both files is that the second one has <section>.

@gautierchomel
Copy link
Member

Using CTRL + ALT + SHIFT + left or right arrow instead of CTRL+Page down or Up. It works in all cases.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

5 participants