Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

When pressing open fullscreen mode, settings and navigation should close #1699

Closed
elcste opened this issue May 31, 2022 · 4 comments
Closed
Assignees

Comments

@elcste
Copy link
Contributor

elcste commented May 31, 2022

When pressing open fullscreen mode, settings or navigation should close if one is open because

  • they are invisible in fullscreen mode
  • but if one is open, then keyboard shortcuts for turning pages do not work.

I open find myself navigating using the ToC or bookmarks, or changing the theme, and then I open fullscreen mode to read but get "stuck" once I finish the page.

@elcste
Copy link
Contributor Author

elcste commented May 31, 2022

I see now this was mentioned (#1197 (comment)), but it's not that bug's specific point.

@panaC
Copy link
Member

panaC commented Jun 1, 2022

good point !

@panaC
Copy link
Member

panaC commented Jun 1, 2022

private handleFullscreenClick() {
this.props.toggleFullscreen(!this.state.fullscreen);
this.setState({ fullscreen: !this.state.fullscreen });

private handleMenuButtonClick(openedSectionMenu?: number | undefined) {
this.setState({
menuOpen: !this.state.menuOpen,
shortcutEnable: this.state.menuOpen,
settingsOpen: false,
openedSectionMenu,
});
}

@panaC panaC self-assigned this Jun 1, 2022
panaC added a commit that referenced this issue Jun 1, 2022
@danielweck danielweck moved this to In Progress in Thorium 2.1.0 Jun 7, 2022
Repository owner moved this from In Progress to Done in Thorium 2.1.0 Jun 8, 2022
danielweck added a commit that referenced this issue Jun 8, 2022
@elcste
Copy link
Contributor Author

elcste commented Jun 8, 2022

Just tested and works great in the dev version! Merci !

I only wish I suggested it before the version 2.0 release :-)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Status: Done
Development

No branches or pull requests

2 participants