Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: ENT-3844 remove extraneous dependencies added during prior work #53

Merged
merged 1 commit into from
Dec 11, 2020

Conversation

binodpant
Copy link
Contributor

@binodpant binodpant commented Dec 11, 2020

Why?

I noted that these two fortawesome libs are used directly by frontend learner portal and are makred as peer deps here but not used within this project. And they are already depended on by FE learner portal. hence they can be safely removed.

These were added in this commit: https://github.com/edx/frontend-enterprise/blob/a461a769faa2766aebe99f6d9de6fb110a54876b/package.json

"@fortawesome/fontawesome-svg-core": "^1.2.17",
"@fortawesome/free-brands-svg-icons": "^5.11.2",
"@fortawesome/free-regular-svg-icons": "^5.12.1",

but the only one actually used here is fortawesome/free-solid-svg-icons

I tested locally by using the new package of frontend-enterprise installed into frontend learner portal

@binodpant binodpant changed the title feat: remove extraneous dependencies added duiing prior work feat: remove extraneous dependencies added during prior work Dec 11, 2020
@binodpant binodpant changed the title feat: remove extraneous dependencies added during prior work feat: ENT-3844 remove extraneous dependencies added during prior work Dec 11, 2020
@binodpant binodpant merged commit d55c5bf into master Dec 11, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants