Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[django-contrib-comments]: Add Support for Django 4.2 #206

Closed
1 of 9 tasks
github-actions bot opened this issue May 31, 2023 · 4 comments
Closed
1 of 9 tasks

[django-contrib-comments]: Add Support for Django 4.2 #206

github-actions bot opened this issue May 31, 2023 · 4 comments

Comments

@github-actions
Copy link

github-actions bot commented May 31, 2023

Description

If latest PyPI release does not have Django 4.2 support, then

  • Verify if latest master/main branch has support for Django 4.2
  • Create issue in the upstream repo for Django 4.2 upgrade if no issue exists already.
  • Create pull request in upstream repo for Django 4.2 support if no pull request exists already.
  • Fork the repo, Add test configurations for Django 4.0, 4.1 and 4.2 in CI
  • Run available django-code-mods to fix the failing tests
  • Fix any remaining Django deprecation warnings or test failures in all the test configurations.
  • Update the Trove classifiers in any setup.py, setup.cfg, or pyproject.toml files
  • Update status in the Dependency Sheet if the package has support for Django 4.2
  • Update the repo support field in the Dependency Upgrade Sheet once a new version with support has been released.
@UsamaSadiq
Copy link
Member

@irtazaakram you can work on this issue.

@irtazaakram
Copy link

The master branch has been updated with Django 4.2, but need a new release. I have created an issue for this here django/django-contrib-comments#193

@carltongibson
Copy link

Copying the comment from the linked issue:

@irtazaakram Please stop spamming multiple projects with these comments. ALL you're talking about here is releasing a package with the updated Trove classifier on PyPI, since the packages have no significant changes needed for 4.2 compatibility.

If you want to help make the PR adding the Trove classifier and preparing the release, rather than pressuring volunteer maintainers into doing work to satisfy your corporate priorities.

Again please do the work to contribute rather than serially spamming ecosystem projects. @nedbat can I please ask that you lay down a better policy here: exactly the same thing occurred for, IIRC, the 3.2 release. The packages are already compatible — or if not, testing and an issue report would be welcome — they just don't have the Trove classifier on PyPI.

All this kind of thing does is put pressure on volunteer maintainers. It's out of line. The folks here are being paid. They could use that to help prepare the releases they're asking for.

@UsamaSadiq
Copy link
Member

Hi @carltongibson
First of all I'd like to apologise for this inconvenience. As per the instructions, since the packages already had the support for Django 4.2 in the latest available release, the issues were not supposed to be created and the internal issue needed to be closed as is.

@irtazaakram has just started contributing as an open source contributor so he is not familiar enough with the process. I'm guessing he confused the support checking step with PyPI classifiers. I'll make the internal issues more descriptive so moving forward we won't have to face such situation again.

Regarding the concern of designing a better policy, 2U team had created internal issues to introduce a step for internal review before creating any issue/pull request against upstream packages. I'll take the responsibility for guiding the contributors properly and making internal review step more rigid to avoid this situation in future.

Once again sorry for the inconvenience.

@UsamaSadiq UsamaSadiq moved this to Todo in Maintenance Jul 13, 2023
@UsamaSadiq UsamaSadiq moved this from Todo to Done in Maintenance Jul 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants